grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-install: locale depends on nls


From: Olaf Hering
Subject: Re: [PATCH] grub-install: locale depends on nls
Date: Mon, 5 Mar 2018 18:18:30 +0100

Am Mon, 5 Mar 2018 17:23:12 +0100
schrieb Daniel Kiper <address@hidden>:

> On Tue, Feb 27, 2018 at 09:39:20AM +0100, Olaf Hering wrote:
> > +grub_install_copy_nls(const char *src, const char *dst)  
> Does not compiler complain that arguments are unused if ENABLE_NLS is not 
> defined?

There are indeed a few non-fatal warnings after the change.

> > +#if (defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)  
> Is not "#if defined(GRUB_UTIL) && defined(ENABLE_NLS)" sufficient?

I copied that from elsewhere.

Will send v2 shortly.

Olaf

Attachment: pgpps45aIsR_y.pgp
Description: Digitale Signatur von OpenPGP


reply via email to

[Prev in Thread] Current Thread [Next in Thread]