[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Better ahci error handling
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] Better ahci error handling |
|
Date: |
Mon, 8 Jan 2018 13:40:30 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Wed, Jan 03, 2018 at 11:36:29AM +0100, Stefan Fritsch wrote:
> On Tue, 2 Jan 2018, Michel Hermier wrote:
>
> > Hi,
> > IS_FATAL_ERROR sounds like a utility macro, I would add a parameter to test
> > the flags and make it return a Bool compatible value.
> > My 2 cents comments.
> > Cheers
>
> Yes, the IS_FATAL_ERROR name is not good. I have renamed it to
> GRUB_AHCI_HBA_PORT_IS_FATAL_MASK.
May I ask you to repost the patch with suggested fixes with your SOB and CC me?
Daniel