Re: [GRUB PARTUUID PATCH V4 0/3] Add PARTUUID detection support

[Nick Vinson]

Hello,

It's been about 3 months since I last asked for a status update.  I've
pulled the latest sources and my patches still apply cleanly.  The
affected files all build without warning or error.  Unfortunately, the
build does fail with the error "No rule to make target
'lib/efi/reboot.c', needed by 'lib/efi/reboot_module-reboot.o'.  Stop.".

I have added my config.log and build.log in case they're needed to help
address that build issue.  I would appreciate it, if someone could let
me know what the status of this patch is from a grub-devel POV is.

Thanks,
Nicholas Vinson

On 07/23/2017 11:28 AM, Vladimir 'phcoder' Serbinenko wrote:
> I plan to allocate entire day this week to grub. I plan on burning down
> the backlog
> 
> On Sun, Jul 23, 2017, 20:02 Nick Vinson <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     Hello,
> 
>     I submitted this patch set back in May and have not heard anything.  I
>     noticed it also has not been merged into the GRUB tree.  Is there some
>     issue with the patches that I still need to fix?  If so, please let me
>     know so I can make the corrections and submit an updated patch set.
> 
>     Thanks,
>     Nicholas Vinson
> 
>     On 05/14/2017 09:26 AM, Nicholas Vinson wrote:
>     > This is an updated patch set for PARTUUID support.  I've retested
>     > against GRUB 2.03 and found no errors.  Because including Steve
>     Kenton's
>     > patches in the last iteration caused confusion, I have removed
>     them from
>     > this version.  I have also removed the flex-2.6.3 compatibility
>     patch as
>     > flex-2.6.4 has been released and is not affected by the same issues.
>     >
>     > Thanks,
>     > Nicholas Vinson
>     >
>     > Changes from Patch v3:
>     >     - Removed flex-2.6.3 compatibility patch
>     >
>     >     - Removed Steve Kenton's patch
>     >
>     > Changes from Patch v2:
>     >     - Added flex-2.6.3 compatibility patch
>     >
>     >     - Fixed a GPT partition read error
>     >
>     >     - Added Steve Kenton's patch
>     >
>     >     - Changed struct grub_part_gpt_type name to struct
>     >       grub_part_gpt_part_guid
>     >
>     >     - Changed grub_part_gpt_type_t typedef name to
>     grub_part_gpt_guid_t
>     >
>     >     - Added sprint_gpt_guid to Steve Kenton's patch
>     >
>     >     - Updated v1 and Steve Kenton's patch to use similar methods when
>     >       reading partition GUIDs.
>     >
>     > Changes from Patch v1:
>     >     - Added GRUB_ENABLE_LINUX_PARTUUID variable description to
>     grub.texi
>     >
>     >     - Removed added gpt_part_guid copy logic from
>     >       grub_gpt_partition_map_iterate()
>     >
>     >     - Removed added NT disk signature copy logic from
>     >       grub_partition_msdos_iterate()
>     >
>     >     - Removed modifications to partition number increment logic
>     >
>     >     - Removed added guid union definition.
>     >
>     >     - Added GRUB_ENABLE_LINUX_PARTUUID to grub-mkconfig.in
>     <http://grub-mkconfig.in> export list
>     >
>     >     - Moved PRINT_GPT_PARTTYPE printing logic to print_gpt_guid()
>     >       function in grub-probe.c
>     >
>     >     - Updated PRINT_GPT_PARTTYPE case to call print_gpt_guid()
>     function
>     >       in grub-probe.c.
>     >
>     >     - Created probe_partuuid() function in grub-probe.c
>     >
>     >     - Updated print == PRINT_PARTUUID check logic in probe() to call
>     >       probe_partuuid().
>     >
>     >     - Updated UUID logic in 10_linux.in <http://10_linux.in> to
>     enable root=PARTUUID feature
>     >       only if GRUB_DISABLE_LINUX_UUID is not set to true,
>     >       and GRUB_DEVICE_PARTUUID is not empty,
>     GRUB_ENABLE_LINUX_PARTUUID
>     >       is set to true.
>     >
>     > Hello,
>     >
>     > This is a request to add PARTUUID detection support grub-probe for MBR
>     > and GPT partition schemes.  The Linux kernel supports mounting the
>     root
>     > filesystem by Linux device name or by the Partition [GU]UID.  GRUB's
>     > mkconfig, however, currently only supports specifying the rootfs
>     in the
>     > kernel command-line by Linux device name unless an initramfs is also
>     > present.  When an initramfs is present GRUB's mkconfig will set the
>     > kernel's root parameter value to either the Linux device name or
>     to the
>     > filesystem [GU]UID.
>     >
>     > Therefore, the only way to protect a Linux system from failing to boot
>     > when its Linux storage device names change is to either manually edit
>     > grub.cfg or /etc/default/grub and append root=PARTUUID=xxx to the
>     > command-line or create an initramfs that understands how to mount
>     > devices by filesystem [G]UID and let grub-mkconfig pass the filesystem
>     > [GU]UID to the initramfs.
>     >
>     > The goal of this patch set is to enable root=PARTUUID=xxx support in
>     > grub-mkconfig, so that users don't have to manually edit
>     > /etc/default/grub or grub.cfg, or create an initramfs for the sole
>     > purpose of having a robust bootloader configuration for Linux.
>     >
>     > Thanks,
>     > Nicholas Vinson
>     >
>     > Nicholas Vinson (3):
>     >   Update grub_gpt_partentry; centralize guid prints
>     >   Add PARTUUID detection support to grub-probe
>     >   Update grub script template files
>     >
>     >  docs/grub.texi               | 13 +++++++
>     >  grub-core/disk/ldm.c         |  2 +-
>     >  grub-core/partmap/gpt.c      |  4 +--
>     >  include/grub/gpt_partition.h |  8 ++---
>     >  util/grub-install.c          |  2 +-
>     >  util/grub-mkconfig.in <http://grub-mkconfig.in>        |  3 ++
>     >  util/grub-probe.c            | 81
>     ++++++++++++++++++++++++++++++++++++--------
>     >  util/grub.d/10_linux.in <http://10_linux.in>      | 13 +++++--
>     >  8 files changed, 101 insertions(+), 25 deletions(-)
>     >
> 
>     _______________________________________________
>     Grub-devel mailing list
>     address@hidden <mailto:address@hidden>
>     https://lists.gnu.org/mailman/listinfo/grub-devel
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

build.log
Description: Text Data

config.log
Description: Text Data

0xD2F6D982.asc
Description: application/pgp-keys

signature.asc
Description: OpenPGP digital signature