Re: [PATCH v2] sparc64: Add blocklist GPT support for SPARC

[Eric Snowberg]

> On Oct 6, 2017, at 8:04 AM, Daniel Kiper <address@hidden> wrote:
> 
> On Thu, May 11, 2017 at 06:25:24PM -0700, Eric Snowberg wrote:
>> Add block-list GPT support for SPARC.  The OBP "load" and "boot" methods
>> are partition aware and neither command can see the partition table. Also
>> neither command can address the entire physical disk. When the install
>> happens, grub generates the block-list entries based on the beginning of the
>> physical disk, not the beginning of the parition. This patch fixes the
>> block-list entries so they match what OBP expects during boot for a GPT
>> disk.
>> 
>> T5 and above now supports GPT as well as VTOC.
>> 
>> This patch has been tested on T5-2 and newer SPARC systems.
>> 
>> Signed-off-by: Eric Snowberg <address@hidden>
>> ---
>> Changes in v2:
>>  Do all GPT offset calculations in setup
>> ---
>> util/setup.c |   26 +++++++++++++++++++++++---
>> 1 files changed, 23 insertions(+), 3 deletions(-)
>> 
>> diff --git a/util/setup.c b/util/setup.c
>> index 8aa5a39..8036307 100644
>> --- a/util/setup.c
>> +++ b/util/setup.c
>> @@ -138,6 +138,9 @@ struct blocklists
>> #ifdef GRUB_SETUP_BIOS
>>   grub_uint16_t current_segment;
>> #endif
>> +#ifdef GRUB_SETUP_SPARC64
>> +  grub_uint64_t gpt_offset;
>> +#endif
> 
> This does not seem to be used below…
> 

I think that is left over from V1, I’ll remove it and send out a new patch.