[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Core TPM support
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH 2/2] Core TPM support |
|
Date: |
Fri, 21 Jul 2017 16:27:16 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/05/2017 11:19 PM, Matthew Garrett wrote:
> Add support for performing basic TPM measurements. Right now this only
> supports extending PCRs statically and only on UEFI.
> ---
[snip]
> +grub_err_t grub_tpm_init(void);
You forgot to remove this function prototype, since the function doesn't exist
anymore in this new version. The rest looks good to me.
Reviewed-by: Javier Martinez Canillas <address@hidden>
Tested-by: Javier Martinez Canillas <address@hidden>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat