grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "arm_coreboot: Support DMA" breaks arm64


From: Leif Lindholm
Subject: Re: "arm_coreboot: Support DMA" breaks arm64
Date: Mon, 5 Jun 2017 11:15:49 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, May 30, 2017 at 04:06:52PM +0000, Vladimir 'phcoder' Serbinenko wrote:
> LGTM

Thanks - so am I OK to push the following?:

>From bb9aa73e172ee284d9b41a0a4657154c355d6f63 Mon Sep 17 00:00:00 2001
From: Leif Lindholm <address@hidden>
Date: Mon, 5 Jun 2017 10:47:35 +0100
Subject: [PATCH] arm64: don't export cache.h

arm64 does not implement grub_arch_sync_dma_caches(), which causes an
error when running grub-mkimage due to the missing exported symbol.
Make the exporting of cache.h conditional on !COND_arm64.
---
 grub-core/Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
index 1045138..622f946 100644
--- a/grub-core/Makefile.am
+++ b/grub-core/Makefile.am
@@ -66,7 +66,9 @@ CLEANFILES += grub_script.yy.c grub_script.yy.h
 
 include $(srcdir)/Makefile.core.am
 
+if !COND_arm64
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/cache.h
+endif
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/command.h
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/device.h
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/disk.h
-- 
2.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]