grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "arm_coreboot: Support DMA" breaks arm64


From: Vladimir 'phcoder' Serbinenko
Subject: Re: "arm_coreboot: Support DMA" breaks arm64
Date: Tue, 30 May 2017 16:06:52 +0000

LGTM

On Wed, May 24, 2017, 13:36 Leif Lindholm <address@hidden> wrote:
Apologies for delay, got knocked out by a bad cold.

On Thu, May 11, 2017 at 06:33:34PM +0000, Vladimir 'phcoder' Serbinenko wrote:
> > Thoughts?
> >
> I don't think that functions in cache.h are used outside of kernel on arm64
> currently. We can just remove cache.h from the list of exported headers

That's true. So, would something like the below be acceptable?

/
    Leif

diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
index 1045138..622f946 100644
--- a/grub-core/Makefile.am
+++ b/grub-core/Makefile.am
@@ -66,7 +66,9 @@ CLEANFILES += grub_script.yy.c grub_script.yy.h

 include $(srcdir)/Makefile.core.am

+if !COND_arm64
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/cache.h
+endif
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/command.h
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/device.h
 KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/disk.h

_______________________________________________
Grub-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/grub-devel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]