[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7
|
From: |
Andrei Borzenkov |
|
Subject: |
Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7 |
|
Date: |
Tue, 4 Apr 2017 19:27:49 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
03.04.2017 11:59, Vladimir 'phcoder' Serbinenko пишет:
> On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov <address@hidden> wrote:
>
>> sblock was local and so considered new variable on every loop
>> iteration.
>>
>> While on it, dynamically allocate buffer to reduce stack usage.
>>
> Looks good. Did you check all instances sizeof, so we don't have sizeof of
> pointer?
> Did you check return paths for free'ing on all of them?
>
There is one common return path, but I committed light version that just
moves variable out of loop; will commit full version after release.