[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] multiboot2: Fix alignment of header tags
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [PATCH] multiboot2: Fix alignment of header tags |
Date: |
Fri, 10 Mar 2017 11:25:11 -0500 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Mar 10, 2017 at 05:13:58PM +0100, Daniel Kiper wrote:
> Header tags have to be 8-bytes aligned. So, fix it.
> Additionally, mention header closing tag in the spec.
>
> Signed-off-by: Daniel Kiper <address@hidden>
Reviewed-by: Konrad Rzeszutek Wilk <address@hidden>
> ---
> doc/multiboot.texi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/multiboot.texi b/doc/multiboot.texi
> index a9c3f16..2e2d7e7 100644
> --- a/doc/multiboot.texi
> +++ b/doc/multiboot.texi
> @@ -408,8 +408,9 @@ and @samp{header_length}), must have a 32-bit unsigned
> sum of zero.
>
> @node Header tags
> @subsection General tag structure
> -Tags constitutes a buffer of structures following each other padded on
> @samp{u32} size.
> -Every structure has following format:
> +Tags constitutes a buffer of structures following each other padded when
> necessary
> +in order for each tag to start at 8-bytes aligned address. Tags are
> terminated by
> +a tag of type @samp{0} and size @samp{8}. Every structure has following
> format:
>
> @example
> @group
> --
> 1.7.10.4
>