Re: [PATCH] Ignore xen all_video module emptiness

[Vladimir 'phcoder' Serbinenko]

Committed with added comment

On Sun, 29 Jan 2017, 11:05 Andrei Borzenkov <address@hidden> wrote:

29.01.2017 12:37, Vladimir 'phcoder' Serbinenko пишет:
> Not tested yet. If there are no opposition I'll test and commit it.
>
>
...
> diff --git a/util/grub-module-verifierXX.c b/util/grub-module-verifierXX.c
> index 9c04caa..c79c1cb 100644
> --- a/util/grub-module-verifierXX.c
> +++ b/util/grub-module-verifierXX.c
...
> -check_symbols (const struct grub_module_verifier_arch *arch, Elf_Ehdr *e)
> +check_symbols (const struct grub_module_verifier_arch *arch,
> +            Elf_Ehdr *e, const char *modname,
> +            const char **whitelist_empty)
>  {
>    Elf_Sym *sym;
>    Elf_Word size, entsize;
> @@ -196,7 +212,12 @@ check_symbols (const struct grub_module_verifier_arch *arch, Elf_Ehdr *e)

I guess it needs some explanation in comments just before this line,
otherwise OK from me.

>    sym = get_symtab (arch, e, &size, &entsize);
>    if (!sym)
>      {
> -      Elf_Shdr *s = find_section (arch, e, ".moddeps");
> +      Elf_Shdr *s;
> +
> +      if (is_whitelisted (modname, whitelist_empty))
> +     return;
> +
> +      s = find_section (arch, e, ".moddeps");
>
>        if (!s)
>       grub_util_error ("no symbol table and no .moddeps section");


_______________________________________________
Grub-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/grub-devel