RE: [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6

[Lin, Keng-Yu (HPS OE-Linux TDC)]

Hi there,
  There has been a while since the patchset is sent. There is no comment so far.
  Wonder if it is in a good shape and will be merged soon?

    Thanks for the reviewing effort. :-)
-kengyu

-----Original Message-----
From: Lin, Keng-Yu (HPS OE-Linux TDC) 
Sent: Friday, December 23, 2016 4:54 PM
To: address@hidden
Cc: address@hidden; Lin, Ken (HPS OE-Linux TDC) <address@hidden>; Knippers, 
Linda <address@hidden>; Ruan, Michael (HPS OE-Linux/VMware TDC) 
<address@hidden>; Chang, Clay (HPS OE-Linux TDC) <address@hidden>; Lin, Keng-Yu 
(HPS OE-Linux TDC) <address@hidden>
Subject: [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6

The patchset is a follow-up to the previous one sent in Auguest.
After talking with Michael Chang, he is happy that we pick up this.

This patchset was tested on a machine with EDK2-derived ROM.
Both ipv4 and ipv6 are tested. The default http port (80) and a specified port 
(we chose 79) are also tested. All passed.

See below for more explanation for each patch.

Aaron Miller (1):
  net: read bracketed ipv6 addrs and port numbers

Keng-Yu Lin (1):
  Add default port in grub_net_app_protocol

This one is the main one in reply the last review.
Besides adding the default port grub_net_app_protocol, this patch also 
shortened the port string and add a comment to the code for adding the brackets 
for un-brackted ipv6 address. The brackets are required based on the testing 
result on the real machine.

For port 0, this is not realistic for the real use, because there is no way for 
the http server to know in advance which port the client will get. However, I 
removed all port 0 checking. From the source-level, port 0 should work.

Michael Chang (6):
  bootp: New net_bootp6 command
  efinet: UEFI IPv6 PXE support
  grub.texi: Add net_bootp6 doument
  bootp: Add processing DHCPACK packet from HTTP Boot
  efinet: Setting network from UEFI device path
  efinet: Setting DNS server from UEFI protocol

Vladimir Serbinenko (1):
  strtoull: Fix behaviour on chars between '9' and 'a'.

Dropped Aaron Miller's patch and use this one since it is now in the grub/next 
branch. One thing to notice is that the test case is missing. It causes 
compiling to fail. We teporarily removed the test case from 
grub-core/Makefile.core.def in our testing.


 docs/grub.texi                        |  17 +
 grub-core/Makefile.core.def           |   5 +
 grub-core/kern/misc.c                 |  13 +-
 grub-core/net/bootp.c                 | 975 +++++++++++++++++++++++++++++++++-
 grub-core/net/drivers/efi/efinet.c    | 445 +++++++++++++++-
 grub-core/net/http.c                  |  21 +-
 grub-core/net/ip.c                    |  39 ++
 grub-core/net/net.c                   |  91 +++-
 grub-core/net/tftp.c                  |   9 +-
 grub-core/tests/lib/functional_test.c |  13 +-
 include/grub/efi/api.h                | 142 ++++-
 include/grub/net.h                    |  75 +++
 12 files changed, 1809 insertions(+), 36 deletions(-)

--
1.8.3.1