[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MULTIBOOT2 DOC PATCH v2 06/11] multiboot2: Add description of EFI i
From: |
Andrei Borzenkov |
Subject: |
Re: [MULTIBOOT2 DOC PATCH v2 06/11] multiboot2: Add description of EFI image handle tags |
Date: |
Mon, 28 Nov 2016 20:59:38 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
24.11.2016 23:40, Daniel Kiper пишет:
> Signed-off-by: Daniel Kiper <address@hidden>
> ---
> doc/multiboot.texi | 28 ++++++++++++++++++++++++++++
> doc/multiboot2.h | 16 ++++++++++++++++
> 2 files changed, 44 insertions(+)
>
> diff --git a/doc/multiboot.texi b/doc/multiboot.texi
> index cc1edab..dca3e62 100644
> --- a/doc/multiboot.texi
> +++ b/doc/multiboot.texi
> @@ -1288,6 +1288,34 @@ u32 | size = 8 |
>
> This tag indicates ExitBootServices wasn't called
>
> address@hidden EFI 32-bit image handle pointer
> address@hidden
> address@hidden
> + +-------------------+
> +u32 | type = 19 |
> +u32 | size = 12 |
> +u32 | pointer |
Why it is not u_phys or u_virt as appropriate?
> + +-------------------+
> address@hidden group
> address@hidden example
> +
> +This tag contains pointer to EFI i386 image handle.
> +Usually it is boot loader image handle.
> +
> address@hidden EFI 64-bit image handle pointer
> address@hidden
> address@hidden
> + +-------------------+
> +u32 | type = 20 |
> +u32 | size = 16 |
> +u64 | pointer |
Same. Again, why there are two tags in the first place? It sounds like
perfect fit for "data of the same size as target architecture
[virtual|physical] address size".
- [MULTIBOOT2 DOC PATCH v2 05/11] multiboot2: Add description of support for EFI boot services, (continued)
[MULTIBOOT2 DOC PATCH v2 06/11] multiboot2: Add description of EFI image handle tags, Daniel Kiper, 2016/11/24
- Re: [MULTIBOOT2 DOC PATCH v2 06/11] multiboot2: Add description of EFI image handle tags,
Andrei Borzenkov <=
[MULTIBOOT2 DOC PATCH v2 07/11] multiboot2: Add description of support for relocatable images, Daniel Kiper, 2016/11/24
[MULTIBOOT2 DOC PATCH v2 08/11] multiboot2: Say that memory maps may not be available on EFI platforms, Daniel Kiper, 2016/11/24
[MULTIBOOT2 DOC PATCH v2 09/11] multiboot2: Add C structure members alignment and padding consideration section, Daniel Kiper, 2016/11/24
[MULTIBOOT2 DOC PATCH v2 10/11] multiboot2: Add me to authors, Daniel Kiper, 2016/11/24
[MULTIBOOT2 DOC PATCH v2 11/11] multiboot2: Bump version to 2.0, Daniel Kiper, 2016/11/24