[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] serial: Poll USB devices if usbX serial port is missing
From: |
Joonas Lahtinen |
Subject: |
Re: [PATCH v2] serial: Poll USB devices if usbX serial port is missing |
Date: |
Mon, 21 Nov 2016 16:05:19 +0200 |
On pe, 2016-11-18 at 15:21 +0300, Andrei Borzenkov wrote:
> On Fri, Nov 18, 2016 at 1:36 PM, Joonas Lahtinen
> >
> > v2:
> > - Use grub_term_poll_usb to avoid module dependency (Andrei)
> >
>
> Hmm ... note that terminal_input/terminal_output also auto-load
> modules that handle serial ports. So this still will not be
> equivalent, it will require user to manually pre-load USB. Did you
> actually test this version of patch? Do you pre-load USB modules
> somewhere?
Nope, I took your word literally and just changed the function.
Assuming it's a rather direct replacement. Excuse for that.
>
> The problem is, infrastructure to handle auto-load lists currently
> belongs to normal mode, while serial may sensibly be used before
> normal is loaded. Not sure what we can do here.
I think this is getting more important when we're seeing increasing
amount of devices without even an internal serial port.
Sounds to me like pulling the auto-loading out of just normal mode
would make sense?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
Re: [PATCH 1/2] .gitignore: Add grub-core/build-grub-module-verifier, Andrei Borzenkov, 2016/11/12