grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] push/pop errno in initrd read file path


From: Josef Bacik
Subject: Re: [PATCH 1/3] push/pop errno in initrd read file path
Date: Fri, 18 Nov 2016 09:51:12 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 11/10/2016 07:49 AM, Daniel Kiper wrote:
On Fri, Mar 11, 2016 at 11:28:33AM -0500, Josef Bacik wrote:
If you try to load an initrd from http and it errors out we will free the initrd
context but continue on because net_tcp_socket_close() will reset the grub_errno
as will grub_initrd_close().  So we'll lose the errno and return GRUB_ERR_NONE
instead of the original error.  Add push/pulls to the appropriate places so we
don't lose our errno.  Thanks,

Signed-off-by: Josef Bacik <address@hidden>

Josef, could you repost whole patch series taking into account Andrei and
Vladimir comments? We would like to have it in upcoming release.


We stopped using grub2 internally, if you want to update them go ahead but I'm not working on grub2 anymore. Thanks,

Josef




reply via email to

[Prev in Thread] Current Thread [Next in Thread]