Re: Patch: Improve HTTP time by sending Connection:close

[Konrad Rzeszutek Wilk]

On Thu, Nov 17, 2016 at 07:32:16PM +0100, Daniel Kiper wrote:
> On Tue, Nov 15, 2016 at 01:43:16PM -0800, Walter Huf wrote:
> > GRUB has a bug where it waits a minimum of 400ms for every file it fetches
> > over HTTP, unless the server serves it with Transfer-Encoding:chunked or
> > the file just happens to be split into 20 TCP packets. When using
> > pxeboot.img built with just pxe and http module (following instructions
> > from https://www.gnu.org/software/grub/manual/html_node/Network.html), this
> > causes an initial text menu to take about 7 seconds to load with all the
> > modules being dynamically fetched.
> 
> I agree that this looks like a bug.
> 
> > The SOB (statement of benefit?) of this patch is to fix this bug with the
> > smallest change to existing data structures and logic.
> 
> I meant Signed-off-by: ...
> In your case it should look like:
> 
> Signed-off-by: Walter Huf <address@hidden>

It is not as simple as that. Putting your SoB means that you:

        Developer's Certificate of Origin 1.1

        By making a contribution to this project, I certify that:

        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.

        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

then you just add a line saying

        Signed-off-by: Random J Developer <address@hidden>