Re: [PATCH 1/2] arm64: Move firmware fdt search into global function

[Daniel Kiper]

On Wed, Nov 16, 2016 at 11:33:26AM +0100, Alexander Graf wrote:
> On 16/11/2016 11:28, Daniel Kiper wrote:
> >On Tue, Nov 15, 2016 at 10:07:39PM +0100, Alexander Graf wrote:

[...]

> >>Uh, the point of the function was to share code between 32bit and 64bit
> >>arm platforms which are completely separate archs.
> >>
> >>There's also effort underway to run with device tree on x86:
> >>
> >>  https://plus.google.com/+ChristopherFriedt/posts/SfDifuC1xsR
> >
> >OK but right know we build FDT code for every EFI platform. This
> >is not nice because not every EFI platform uses/knows FDT (at least
> >today). So, I think that we should revert that patch and then you
> >can provide another patch which puts FDT code in separate file, e.g.
> >grub-core/kern/efi/fdt.c build only on platforms supporting FDT.
> >Does it make sense?
>
> It probably makes a lot more sense to move it to that file rather than
> revert the patches, as this is patch 1/2 and you would have to revert
> the actual 32bit arm enablement as well, breaking bisectability for
> 32bit arm.

OK, let's go that way. I am waiting for your patch(es).

Daniel