[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command s
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v6 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command support |
Date: |
Thu, 3 Nov 2016 16:19:55 +0100 |
User-agent: |
Mutt/1.3.28i |
On Tue, Jul 26, 2016 at 05:13:42PM +0800, address@hidden wrote:
> From: Fu Wei <address@hidden>
>
> This patch adds the support of xen_boot command:
> xen_hypervisor
> xen_module
>
> Also add a new "feature_xen_boot" to indicate this grub support
> xen_boot command.
>
> Signed-off-by: Fu Wei <address@hidden>
> ---
> grub-core/normal/main.c | 2 +-
> util/grub.d/20_linux_xen.in | 13 ++++++++++---
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
> index 78a70a8..3402a05 100644
> --- a/grub-core/normal/main.c
> +++ b/grub-core/normal/main.c
> @@ -488,7 +488,7 @@ static const char *features[] = {
> "feature_chainloader_bpb", "feature_ntldr", "feature_platform_search_hint",
> "feature_default_font_path", "feature_all_video_module",
> "feature_menuentry_id", "feature_menuentry_options", "feature_200_final",
> - "feature_nativedisk_cmd", "feature_timeout_style"
> + "feature_nativedisk_cmd", "feature_timeout_style", "feature_xen_boot"
I do not like it. This is not generic feature but ARM specific one.
Hence, we should not announce it as generic stuff. Then...
> };
>
> GRUB_MOD_INIT(normal)
> diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_linux_xen.in
> index c48af94..231e640 100644
> --- a/util/grub.d/20_linux_xen.in
> +++ b/util/grub.d/20_linux_xen.in
> @@ -122,16 +122,23 @@ linux_entry ()
> else
> xen_rm_opts="no-real-mode edd=off"
> fi
> - multiboot ${rel_xen_dirname}/${xen_basename} placeholder
> ${xen_args} \${xen_rm_opts}
> + if [ "x\$feature_xen_boot" != xy ]; then
...we should consult $grub_platform and/or $grub_cpu here.
Daniel
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v6 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command support,
Daniel Kiper <=