[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/8] misc: fix invalid character recongition in strto*l
From: |
Michael Chang |
Subject: |
[PATCH 1/8] misc: fix invalid character recongition in strto*l |
Date: |
Wed, 3 Aug 2016 14:34:41 +0800 |
From: Aaron Miller <address@hidden>
Would previously allow digits larger than the base and didn't check that
subtracting the difference from 0-9 to lowercase letters for characters
larger than 9 didn't result in a value lower than 9, which allowed the
parses: ` = 9, _ = 8, ^ = 7, ] = 6, \ = 5, and [ = 4
---
grub-core/kern/misc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
index d1a54df..3a14d67 100644
--- a/grub-core/kern/misc.c
+++ b/grub-core/kern/misc.c
@@ -394,9 +394,13 @@ grub_strtoull (const char *str, char **end, int base)
if (digit > 9)
{
digit += '0' - 'a' + 10;
- if (digit >= (unsigned long) base)
+ /* digit <= 9 check is needed to keep chars larger than
+ '9' but less than 'a' from being read as numbers */
+ if (digit >= (unsigned long) base || digit <= 9)
break;
}
+ if (digit >= (unsigned long) base)
+ break;
found = 1;
--
2.6.6
- Patches to support UEFI HTTP Boot IPv4 and IPv6, Michael Chang, 2016/08/03
- [PATCH 1/8] misc: fix invalid character recongition in strto*l,
Michael Chang <=
- [PATCH 2/8] net: read bracketed ipv6 addrs and port numbers, Michael Chang, 2016/08/03
- [PATCH 4/8] efinet: UEFI IPv6 PXE support, Michael Chang, 2016/08/03
- [PATCH 5/8] grub.texi: Add net_bootp6 doument, Michael Chang, 2016/08/03
- [PATCH 6/8] bootp: Add processing DHCPACK packet from HTTP Boot, Michael Chang, 2016/08/03
- [PATCH 7/8] efinet: Setting network from UEFI device path, Michael Chang, 2016/08/03
- [PATCH 8/8] efinet: Setting DNS server from UEFI protocol, Michael Chang, 2016/08/03
- [PATCH 3/8] bootp: New net_bootp6 command, Michael Chang, 2016/08/03