[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Install to LVM PVs
From: |
Andrei Borzenkov |
Subject: |
Re: [PATCH] Install to LVM PVs |
Date: |
Mon, 9 May 2016 09:07:33 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 |
08.05.2016 16:01, Dryden Personalis пишет:
>
>>> - if (fs_probe)
>>> + if (!is_lvm && fs_probe)
>>
>> No, we want to probe for FS here to eliminate corner case of both PV and
>> FS metadata.
>
> You mean you want to change it to:
>
No, I do not want to change it at all. It should remain as is and always
probe for FS so that test below actually works
...
>> And you need to add check for LVM here
>>
>> if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || (is_ldm
>> && fs))
>
> I take it you mean:
>
> if (!is_lvm && (ctx.multiple_partmaps || (ctx.dest_partmap && fs) ||
> (is_ldm && fs)))
>
I mean
if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || ((is_ldm ||
is_lvm) && fs))
Re: [PATCH] Install to LVM PVs, Andrei Borzenkov, 2016/05/08