Re: Bugs and tasks for 2.02[~rc1]

[Andrei Borzenkov]

04.03.2016 23:06, Peter Jones пишет:
> On Wed, Mar 02, 2016 at 03:01:03PM +0000, Vladimir 'phcoder' Serbinenko wrote:
>> Hello, all. I went through the list of bugs and created a shortlist of bugs
>> that need to be looked at for 2.02. I have marked them with plan_release_id
>> set to 2.02.
>> Statistics: [1]
>> Search (with loads of false positives unfortunately): [2]
>> Not every bug there is a release blocker, for some of them it just would be
>> nice to know status before releasing. Some of them are probably already
>> fixed.
>>
>> Additionally I created a category "Hardware specific" [3]. Bugs there are
>> not release blockers but fixing them could benefit the release.
> 
> In the interest of fixing them up eventually, here's a chunk
> of ones that look reasonably well-suited for upstream without much work
> on them, which I've rebased against your master branch today.
> 
> https://github.com/vathpela/grub2-fedora/tree/for-upstream
> 
> Most of these are not critical for this release - really only 3 of them.
> Here are some notes on each; I can send them individually to the list if
> you think it's worthwhile.
> 
> There are only a couple that are "critical", and we really want in this
> release:
> 
> bf4d216 Fix crash on http

Fixed differently in 92c8f58d973a621890e302cba3d80fe0bbc208d7

> 78b3509 Update to minilzo-2.08

I know. But the sheer size of update makes me afraid of doing it now.

> eaa05aa Failed config now returns exit code (#1252311)
> 

I think it makes sense.

> Then these are just generic network handling patches:
> 
> 836b528 DHCP client ID and UUID options added.

Use case would be interesting. You can query arbitrary option already.

> eb1adf5 trim arp packets with abnormal size
> 

nb is not used anywhere in this branch, so I do not understand what this
code does at all.

> And these are hardware specific.  They're not critical, in the sense
> that I can keep carrying them if you have any problems and we can work
> it out for the /next/ release.
> 
> beee9fc Add vlan-tag support on IBM PPC machines

Yes, openSUSE (and I think SUSE) also carries variant of this patch. We
probably need to revisit it.

> 93a6fae IBM client architecture (CAS) reboot support

Is in (open)SUSE as well

> 297d32d for ppc, reset console display attr when clear screen

Does not apply cleanly to upstream (is on top of some other patch?)

> 0ca5375 Disable GRUB video support for IBM power machines
> 

Is in (open)SUSE as well

> 2f3c666 Add support for UEFI operating systems returned by os-prober

We already support it for quite some time, although differently (based
on os-prober support).

> 05f2dc3 Make efi machines load an env block from a variable

This needs discussion. As well, as openSUSE "store environment block in
btrfs reserved area" patch. And there was intention to use PV reserved
areas for it as well.

> 1f1a695 Make "exit" take a return code.
> 

What about
https://lists.gnu.org/archive/html/grub-devel/2016-01/msg00049.html and
followup?

> The rest are all about the git repo and compilers and similar.  These
> are well into "nice to have" for 2.02.  I can re-send them after the
> release, they're just what's left on my list that's pretty close to
> ready for upstream.
> 
> cb62c40 Mark po/exclude.pot as binary so git won't try to diff nonprintables.

Does it cause a problem? It does not look like there are many of them.

> e0bb91a Fix bzr's ignore artificats in .gitignore
> ecaecc9 Add some __unused__ where gcc 5.x is more picky about it.

How this can become unused?

>  grub_gettext_env_write_lang (struct grub_env_var *var
>                            __attribute__ ((unused)), const char *val)
>   {
>  -  grub_err_t err;
>  +  grub_err_t __attribute__((__unused__)) err;
>     err = grub_gettext_init_ext (&main_context, val, grub_env_get 
> ("locale_dir"),
>                              grub_env_get ("prefix"));
>     if (err)

And in normal, entry is used. So more detailed explanation how either of
them become unused is needed (and BTW it is compiled with gcc 5.x on
openSUSE and apparently without errors).


> e704140 Move bash completion script (#922997)

Well, this is obvious compatibility question. Is there any way to detect
it at configure time? Does bash have pkg-config or similar?

> bc5d351 Allow "fallback" to include entries by title, not just number.

What about multiple entries? fallback allows them.

> 7401bf6 Honor a symlink when generating configuration by grub2-mkconfig

Makes sense

> 5212412 Fix bad test on GRUB_DISABLE_SUBMENU.

What is bad here? The documented valued is "y".

> 73545c7 Add GRUB_DISABLE_UUID.
> 

If name as detected by GRUB is correct, there will be no search because
hints will be correct (just direct verification that device is indeed
correct). If name is wrong you need search, otherwise you fail to boot
or boot wrong binary. I do not see what we gain here.

>> I would also appreciate if distros would tell which patches they would
>> carry if 2.02 was released as it is now. If some patches are in more than 1
>> distro we probably need to look into including them.
> 
> Well, I have a bunch of patches that need to be clean up (or even
> re-examined), and I've also got the secure-boot branch here:
> 
> https://github.com/vathpela/grub2-fedora/tree/sb
> 
> Which is all the patches distros should be carrying to work with Secure
> Boot correctly.  This branch is also recently rebased against master,
> though I'm not sure what the current thinking is regarding their path
> upstream.
> 

Personally I'd rather include support for it. I'm tired of linux vs.
linuxefi nightmare, and patches have been in the wild long enough.