Re: [PATCH 1/2] disk: Add support for device-specific malloc function

[Leif Lindholm]

On Tue, Mar 01, 2016 at 10:46:16PM +0300, Andrei Borzenkov wrote:
> >> I cannot reproduce it on x86_64 (also with mm-debug enabled) and I do
> >> not know how to load standalone image on ppc; is it possible to use QEMU
> >> to run ARM64 (I assume you have it)? If not what are options to test it?
> >>
> >> Anyway, there was one problem I fixed later (although I did not get any
> >> issue before as well), I attach updated version. Thank you for testing!
> > 
> > I can confirm that:
> > 1) The first patch exhibits no bad behaviour on QEMU [1].
> > 2) The second patch exhibits no bad behaviour on either QEMU nor HW.
> > 
> > This still generates fixups in efidisk for each call though.
> 
> Of course; it was intended to add framework for direct-to-cache IO, it
> did not change alignment.

Sure.

> > Could I rework my disk->malloc patch on top of this for 2.02 release?
> 
> Of course!

Splendid. Coming up.

> Not sure whether it is 2.02 material though, but we can keep
> it in next then. Hopefully 2.03 won't take so long :)

Well, it is a <=2x slowdown, and not just on platforms that previously
broke, but also on any platforms that specified alignment that was not
previously obeyed (but still worked).

> > /
> >     Leif
> > 
> > [1] qemu-system-aarch64 -m 1024 -cpu cortex-a57 -M virt -bios
> > QEMU_EFI.fd -nographic -hda fat:fat/
> > With QEMU_EFI.fd from
> > http://releases.linaro.org/components/kernel/uefi-linaro/16.02/debug/qemu64/
> > And fat/ being a directory holding the image generated with 
> > grub-mkstandalone.
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> > 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel