grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] disk: Add support for device-specific malloc function


From: Andrei Borzenkov
Subject: Re: [PATCH 1/2] disk: Add support for device-specific malloc function
Date: Tue, 1 Mar 2016 22:46:16 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

01.03.2016 20:11, Leif Lindholm пишет:
> On 24 February 2016 at 17:40, Andrei Borzenkov <address@hidden> wrote:
>> 24.02.2016 16:57, Leif Lindholm пишет:
>>> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote:
>>>>>> Could you test attached patch with your alignment fixes on top. This
>>>>>> implements my idea of using shared buffers. Seems to work in naive 
>>>>>> testing.
>>>>>
>>>>> Testing this with a grub-mkstandalone image, I get:
>>>>>
>>>>> kern/dl.c:556: flushing 0x10f1 bytes at 0x9ffb5ac20
>>>>> kern/dl.c:649: module name: tar
>>>>> kern/dl.c:650: init function: 0x9ffb5b220
>>>>> kern/disk.c:217: Opening `memdisk'...
>>>>> kern/fs.c:56: Detecting tarfs...
>>>>>
>>>>> And then spectacular crash in UEFI due to an EL2 translation fault.
>>>>
>>>> To be sure - is it with my patch alone or with your patches? If some
>>>> more patches are used - could you send exact diff to trunk to avoid
>>>> misunderstanding?
>>>
>>> Double checked with only your patch on top of
>>> 1b782e902e69516f82158203674d4951a40c82d4 (previously running with
>>> _only_ my alignment fixup in efidisk.c). Same behaviour.
>>
>> I cannot reproduce it on x86_64 (also with mm-debug enabled) and I do
>> not know how to load standalone image on ppc; is it possible to use QEMU
>> to run ARM64 (I assume you have it)? If not what are options to test it?
>>
>> Anyway, there was one problem I fixed later (although I did not get any
>> issue before as well), I attach updated version. Thank you for testing!
> 
> I can confirm that:
> 1) The first patch exhibits no bad behaviour on QEMU [1].
> 2) The second patch exhibits no bad behaviour on either QEMU nor HW.
> 
> This still generates fixups in efidisk for each call though.

Of course; it was intended to add framework for direct-to-cache IO, it
did not change alignment.

> Could I rework my disk->malloc patch on top of this for 2.02 release?
> 

Of course! Not sure whether it is 2.02 material though, but we can keep
it in next then. Hopefully 2.03 won't take so long :)

> /
>     Leif
> 
> [1] qemu-system-aarch64 -m 1024 -cpu cortex-a57 -M virt -bios
> QEMU_EFI.fd -nographic -hda fat:fat/
> With QEMU_EFI.fd from
> http://releases.linaro.org/components/kernel/uefi-linaro/16.02/debug/qemu64/
> And fat/ being a directory holding the image generated with grub-mkstandalone.
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]