[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead o
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants |
Date: |
Thu, 18 Feb 2016 18:15:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 18, 2016 at 11:35:52AM +0100, Juergen Gross wrote:
> On 18/02/16 11:30, Daniel Kiper wrote:
> > On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote:
> >> Various features and parameters of a pv-kernel are specified via
> >> elf notes in the kernel image. Those notes are part of the interface
> >> between the Xen hypervisor and the kernel.
> >>
> >> Instead of using num,bers in the code when interpreting the elf notes
> >> make use of the header supplied by Xen for that purpose.
> >>
> >> Signed-off-by: Juergen Gross <address@hidden>
> >
> > Yummy! Just one nitpick.
> >
> > Reviewed-by: Daniel Kiper <address@hidden>
> >
> >> ---
> >> grub-core/loader/i386/xen_fileXX.c | 19 +--
> >> include/xen/elfnote.h | 281
> >> +++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 291 insertions(+), 9 deletions(-)
> >> create mode 100644 include/xen/elfnote.h
[...]
> >> +/*
> >> + * Local variables:
> >> + * mode: C
> >> + * c-file-style: "BSD"
> >> + * c-basic-offset: 4
> >> + * tab-width: 4
> >> + * indent-tabs-mode: nil
> >> + * End:
> >> + */
> >
> > I am not sure that Emacs footer should be copied to GRUB2 source.
>
> Other xen include files contain it, too.
If maintainer do not complain I will do not object.
Daniel
- Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader, (continued)
- Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader, Juergen Gross, 2016/02/18
- Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader, Lennart Sorensen, 2016/02/18
- Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader, Juergen Gross, 2016/02/18
- Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader, Lennart Sorensen, 2016/02/19
- Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader, Daniel Kiper, 2016/02/18
- [PATCH v3 06/10] xen: factor out allocation of special pages into separate function, Juergen Gross, 2016/02/17
- [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants, Juergen Gross, 2016/02/17
- [PATCH v3 10/10] xen: add capability to load p2m list outside of kernel mapping, Juergen Gross, 2016/02/17
- [PATCH v3 05/10] xen: factor out p2m list allocation into separate function, Juergen Gross, 2016/02/17
- [PATCH v3 09/10] xen: modify page table construction, Juergen Gross, 2016/02/17
- [PATCH v3 01/10] xen: make xen loader callable multiple times, Juergen Gross, 2016/02/17