[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg
From: |
Andrei Borzenkov |
Subject: |
Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg |
Date: |
Sun, 14 Feb 2016 20:20:50 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
14.02.2016 16:26, Vladimir 'phcoder' Serbinenko пишет:
> Le dim. 14 févr. 2016 14:21, Shea Levy <address@hidden> a écrit :
>
>> This patch uses grub_file_open, but the android bootimg is a disk, not
>> a file. You mentioned something about file_offset_open, but that also
>> expects an input file, not a disk. Should I modify your patch with my
>> code I wrote to create a grub_file_t from an android_bootimg disk
>> device, or is there another approach?
>>
> We already have syntax (hd0,1)+<number of sectors> that we use for i.a.
> chainloader perhaps we should extend it to have (hd0,1)+ meaning whole disk
> as file? Or even allow the disk to be opened with GRUB_file_open? I'd like
> a second opinion on this. Andrei, what do you think?
>
Yes, it was discussed just recently on help-grub. I'd prefer ($dev)+ as
explicit indication that we want blocklists.
The practical problem is that we must allow unknown file size. I am not
sure how deep changes are required. But as the trivial example, what "ls
-l ($dev)+" is going to output? Is "test -s ($dev)+" true or false when
size is unknown?
- [PATCH v3 0/3] Android bootimg support, Shea Levy, 2016/02/08
- [PATCH v3 2/3] i386: Add support for loading from android bootimg, Shea Levy, 2016/02/08
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Vladimir 'φ-coder/phcoder' Serbinenko, 2016/02/12
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Shea Levy, 2016/02/12
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Vladimir 'phcoder' Serbinenko, 2016/02/12
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Shea Levy, 2016/02/12
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Vladimir 'φ-coder/phcoder' Serbinenko, 2016/02/12
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Andrei Borzenkov, 2016/02/13
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Shea Levy, 2016/02/14
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Vladimir 'phcoder' Serbinenko, 2016/02/14
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg,
Andrei Borzenkov <=
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Seth Goldberg, 2016/02/14
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Andrei Borzenkov, 2016/02/14
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Seth Goldberg, 2016/02/14
- Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg, Vladimir 'phcoder' Serbinenko, 2016/02/15
[PATCH v3 3/3] Add support for loading initrd from android bootimg, Shea Levy, 2016/02/08
[PATCH v3 1/3] Add helper functions to interact with android bootimg disks., Shea Levy, 2016/02/08