grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] normal: fix get_logical_num_lines


From: Michael Chang
Subject: Re: [PATCH] normal: fix get_logical_num_lines
Date: Mon, 28 Dec 2015 12:28:08 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Dec 28, 2015 at 12:09:58PM +0800, Michael Chang wrote:
> On Thu, Dec 24, 2015 at 02:48:34PM +0300, Andrei Borzenkov wrote:
> > It sounds like we need
> > 
> > string_width = grub_getstringwidth (linep->buf, linep->buf +
> > linep->len, term_screen->term);
> > if (!string_width)
> >   return 1;
> > return (string_width + (unsigned) term_screen->geo.entry_width - 1) /
> > (unsigned) term_screen->geo.entry_width;
> > 
> > Could you test if it works for you?
> 
> Yes. It works great.

Hi Andrei,

I found we had a down stream bug opened for the problem a while ago that
could be fixed by the patch.

https://bugzilla.suse.com/show_bug.cgi?id=943585

So please consider to commit your patch if you think it's ready to go as
well after the testing.

Thanks,
Michael



reply via email to

[Prev in Thread] Current Thread [Next in Thread]