Re: [PATCH] Allow to add/change menu entry class defaults.

[Robin Schneider]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 23.12.2015 07:58, Andrei Borzenkov wrote:
> On Tue, Dec 22, 2015 at 6:19 PM, Robin Schneider <address@hidden> wrote:
>> Useful for changing the default access level for menu entries when using 
>> GRUBs password protection feature.
>> 
>> Ansible role which makes use of this patch: 
>> https://github.com/debops/ansible-grub/pull/7
>> 
> 
> That's overcomplicated. The first class found wins and you will not define
> them unless you have them. So just having
> 
> class="$GRUB_..._CLASS --class ..."
> 
> is really enough.

Thanks for the input. I agree that my first patch was probably a bit to
flexible. I attached a updated patch.

> 
>> Let me know what you think.
>> 
> 
> I'm not sure I like turning grub-mkconfig into kitchen sink, but yes, that
> probably makes sense. It allows easy vendor-specific icons without need to
> patch grub every time.
> 
>> -CLASS="--class gnu-linux --class gnu --class os --class xen"
> 
> I guess "--class xen" should be in front as most specific (unrelated to
> your patch).
> 
> I have half baked patch lying around that tries to use more sensible icons
> in os-prober as well. May be it's time to revisit it.

- -- 
Live long and prosper
Robin `ypid` Schneider
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJWewoKAAoJEIb9mAu/GkD4tJoQAMtvZcUGrksI0VtCVOJvibrr
2/NN2B2191blBIgi9HffciLUDaI3zX1g3dWwhXh0PYLdMmxyfbR3ewK/bzHWN9gg
amCGsyPPbaWBpsE6c2jhLDqFX+on67DCCXiCS4QJX+u31ZwRbZhqhekAvZxvH00W
pju/2WEMQv4CA15lBvBYB/y6Sux1sNyl/4jdC5ZvtAgsNAj+Z1ADebSsi7G+ym48
N1gbjgFOR1p4ORfSKjhHvGAfJ/8JaNatphp1BMYJImozy/ktZC+vbr+7N/tc/LW2
XWxpi3drKM2x8kZerGA4vITVjTxWZyrkQtErRQPROE6r+NxoqUotzny7y2KSZtCB
3ncEn10sA360o5TLnY5WCqrN7XbLh73T/g7ePWCumy/IIKAY9oPuxzFI/vLElzDf
QBAhL/G7GYTRJX5nwRVbeMwwhcx+UrxllSSLswcLZCCpfO2XQXDSjlZiGVfvoRMS
oxmF/kQ5GD2X3Chs33gX4cPCE4NPf1xdg0mQEnpx8e3RcdaLR5kki8p8mi97ME+j
LyMJDUZsbnrz0ylljdieDJWHnHFLrRuj4Qksn0bWUTG/+1zSSX66rzGVzP9/pwKv
/3JkN2D7q3aTBcBts9BzeJgomi1iJtDsbd03ve1SiTX9iUH+6lylToxtuCT3T4jX
SF0yyzjjewj7idRFrhH6
=JF0U
-----END PGP SIGNATURE-----

0001-Allow-to-add-change-menu-entry-class-defaults.patch
Description: Text Data

0001-Allow-to-add-change-menu-entry-class-defaults.patch.sig
Description: PGP signature