Re: [PATCH] emu: fix unusable terminal after exit

[Andrei Borzenkov]

On Wed, Dec 23, 2015 at 12:49 PM, Michael Chang <address@hidden> wrote:
> The grub-emu's grub_exit function will exit immediately without any
> housekeeping work for restoring terminal settings and leaves unusable
> terminal in the end. Fix the problem by calling grub_reboot to allow
> doing the housekeeping work and restoring the terminal settings.
>
> ---
>  grub-core/commands/minicmd.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/grub-core/commands/minicmd.c b/grub-core/commands/minicmd.c
> index a3a1182..63ffeb5 100644
> --- a/grub-core/commands/minicmd.c
> +++ b/grub-core/commands/minicmd.c
> @@ -181,7 +181,11 @@ grub_mini_cmd_exit (struct grub_command *cmd 
> __attribute__ ((unused)),
>                     int argc __attribute__ ((unused)),
>                     char *argv[] __attribute__ ((unused)))
>  {
> +#if defined (GRUB_MACHINE_EMU)
> +  grub_reboot ();
> +#else
>    grub_exit ();
> +#endif
>    /* Not reached.  */
>  }
>

No, please. Just make EMU grub_exit do the right thing (assuming it is
the right thing :)