grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: grub causing NVDIMMs to be treated as normal memory


From: Elliott, Robert (Persistent Memory)
Subject: RE: grub causing NVDIMMs to be treated as normal memory
Date: Thu, 3 Dec 2015 17:50:17 +0000

> > -----Original Message-----
> > From: address@hidden [mailto:grub-devel-
> > address@hidden On Behalf Of Vladimir 'f-
> > coder/phcoder' Serbinenko
> > Sent: Friday, November 27, 2015 5:08 AM
> > To: The development of GNU GRUB <address@hidden>
> > Subject: Re: grub causing NVDIMMs to be treated as normal memory
> >
> > What about this patch for the passing of pram?
> ...
> > --- a/include/grub/memory.h
> > +++ b/include/grub/memory.h
> > @@ -30,6 +30,7 @@ typedef enum grub_memory_type
> >      GRUB_MEMORY_ACPI = 3,
> >      GRUB_MEMORY_NVS = 4,
> >      GRUB_MEMORY_BADRAM = 5,
> > +    GRUB_MEMORY_PRAM = 7,
...

Here is a proposed patch series expanding upon that.  I compiled
the efiemu changes but am not sure how to test them.  I did test
that lsnvimm properly displays the new type name.

I suggest bumping the version number so we have a way to
distinguish grubs that destroy NVDIMM data from ones that
don't.  It looks like grub has been stuck on "2.02~beta2" for
about two years, which is very confusing.  An update to NEWS
should be included with that patch.


Robert Elliott (4):
  Translate UEFI persistent memory type
  Add persistent memory type to efiemu
  efiemu: Handle all reserved UEFI memory map types the same way
  Bump version to 2.03

 configure.ac                |  2 +-
 grub-core/commands/lsmmap.c |  2 ++
 grub-core/efiemu/mm.c       | 25 ++++++++++++++++++++++---
 grub-core/mmap/efi/mmap.c   | 11 +++++++++++
 include/grub/efi/api.h      |  1 +
 include/grub/memory.h       |  2 ++
 6 files changed, 39 insertions(+), 4 deletions(-)

---
Robert Elliott, HPE Persistent Memory

Attachment: 0001-Translate-UEFI-persistent-memory-type.patch
Description: 0001-Translate-UEFI-persistent-memory-type.patch

Attachment: 0002-Add-persistent-memory-type-to-efiemu.patch
Description: 0002-Add-persistent-memory-type-to-efiemu.patch

Attachment: 0003-efiemu-Handle-all-reserved-UEFI-memory-map-types-the.patch
Description: 0003-efiemu-Handle-all-reserved-UEFI-memory-map-types-the.patch

Attachment: 0004-Bump-version-to-2.03.patch
Description: 0004-Bump-version-to-2.03.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]