grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] efinet: check for broken firmware


From: Josef Bacik
Subject: Re: [PATCH] efinet: check for broken firmware
Date: Fri, 13 Nov 2015 10:01:50 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 11/13/2015 09:38 AM, Andrei Borzenkov wrote:
On Fri, Nov 13, 2015 at 5:30 PM, Josef Bacik <address@hidden> wrote:
@@ -291,6 +286,9 @@ grub_efinet_findcards (void)
                                      0, &num_handles);
     if (! handles)
       return;
+
+  attributes = grub_snp_attributes();
+
     for (handle = handles; num_handles--; handle++)
       {
         grub_efi_simple_network_t *net;
@@ -319,8 +317,7 @@ grub_efinet_findcards (void)
            && GRUB_EFI_DEVICE_PATH_SUBTYPE (parent) ==
GRUB_EFI_MAC_ADDRESS_DEVICE_PATH_SUBTYPE)
          continue;

-      net = grub_efi_open_protocol (*handle, &net_io_guid,
-                                   GRUB_EFI_OPEN_PROTOCOL_GET_PROTOCOL);
+      net = grub_efi_open_protocol (*handle, &net_io_guid, attributes);


No, we cannot open exclusively here, it will destroy autocnfiguration
information we need later. You need to add conditional in open_card.


The autoconfig stuff still works later for me but I can change it back.

Thaty would mean your firmware probably is SNP based and not MNP
based. But it will definitely break autoconfig for others - was there,
done that :)


Fair enough, looks like this firmware is 2.3.1 so theoretically has MNP, I'll try and track down this solaris mnp driver and see if I can get it to work. Thanks,

Josef



reply via email to

[Prev in Thread] Current Thread [Next in Thread]