[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator |
|
Date: |
Thu, 12 Nov 2015 14:45:17 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 |
On 10.11.2015 15:38, Daniel Kiper wrote:
>>> - if (entry_specified)
>>> > > + if (keep_bs && efi_entry_specified)
>>> > > + grub_multiboot_payload_eip = efi_entry;
>>> > > + else if (entry_specified)
>>> > > grub_multiboot_payload_eip = entry;
>>> > >
>> > This seems redundant.
> What is wrong here?
I just mean that if we use a single structure this code could go away
signature.asc
Description: OpenPGP digital signature