[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] ieee1275: ofdisk memory leak
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH 2/3] ieee1275: ofdisk memory leak |
|
Date: |
Mon, 26 Oct 2015 23:03:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.2.0 |
On 26.10.2015 22:43, Eric Snowberg wrote:
> Fix memory leak added within commit:
> 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to
> query block-size if disk doesn't have it.”
>
Committed, thanks
> Signed-off-by: Eric Snowberg <address@hidden>
> ---
> grub-core/disk/ieee1275/ofdisk.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/grub-core/disk/ieee1275/ofdisk.c
> b/grub-core/disk/ieee1275/ofdisk.c
> index 4a5632c..297f058 100644
> --- a/grub-core/disk/ieee1275/ofdisk.c
> +++ b/grub-core/disk/ieee1275/ofdisk.c
> @@ -432,7 +432,10 @@ grub_ofdisk_open (const char *name, grub_disk_t disk)
>
> err = grub_ofdisk_get_block_size (devpath, &block_size, op);
> if (err)
> - return err;
> + {
> + grub_free (devpath);
> + return err;
> + }
> if (block_size != 0)
> {
> for (disk->log_sector_size = 0;
> @@ -443,6 +446,7 @@ grub_ofdisk_open (const char *name, grub_disk_t disk)
> disk->log_sector_size = 9;
> }
>
> + grub_free (devpath);
> return 0;
> }
>
>
signature.asc
Description: OpenPGP digital signature