[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C |
Date: |
Mon, 10 Aug 2015 16:31:10 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jul 20, 2015 at 04:29:16PM +0200, Daniel Kiper wrote:
> Current early command line parser implementation in assembler
> is very difficult to change to relocatable stuff using segment
> registers. This requires a lot of changes in very weird and
> fragile code. So, reimplement this functionality in C. This
> way code will be relocatable out of the box and much easier
> to maintain.
>
> Suggested-by: Andrew Cooper <address@hidden>
> Signed-off-by: Daniel Kiper <address@hidden>
I did not look at the str* functions that were added in but just
at how the parameters parsing was done. Also at the assembler code and
with that
Reviewed-by: Konrad Rzeszutek Wilk <address@hidden>
.. snip..
> diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c
> new file mode 100644
> index 0000000..5ea50a4
> --- /dev/null
> +++ b/xen/arch/x86/boot/cmdline.c
> @@ -0,0 +1,396 @@
> +/*
> + * Copyright (c) 2015 Oracle Co.
Oracle Corporation.
- Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C,
Konrad Rzeszutek Wilk <=