Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

[Andrei Borzenkov]

В Wed, 15 Jul 2015 19:42:39 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> 
> > It is possible to compile using "--target=powerpc -Wl,-EB" - this works
> > on all three ppc, ppc64 and ppc64le, but this means hardcoding GNU ld
> > dependency.
> > 
> Thanks for this info.
> See attached patch

Test has to come before asm tests (so that we are sure to compile
for the right target).

But real problem is that -Wl,-EB has to be added to TARGET_LDFLAGS only

 [  106s] configure:24950: clang -c -v -Wall -W -Wshadow
 -Wpointer-arith -Wundef -Wchar-subscripts -Wcomment -Wdeprecated-declarations 
-Wdisabled-optimization -Wdiv-by-zero -Wfloat-equal -Wformat-extra-args 
-Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-declaration 
-Wimplicit-int -Wmain -Wmissing-braces -Wmissing-format-attribute -Wmultichar 
-Wparentheses -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wswitch 
-Wtrigraphs -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label 
-Wunused-parameter -Wunused-value  -Wunused-variable -Wwrite-strings 
-Wnested-externs -Wstrict-prototypes -g -Wredundant-decls -Wmissing-prototypes 
-Wmissing-declarations -Wcast-align  -Wextra -Wattributes -Wendif-labels 
-Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wmissing-field-initializers 
-Wnonnull -Woverflow -Wvla -Wpointer-to-int-cast -Wstrict-aliasing 
-Wvariadic-macros -Wvolatile-register-var -Wpointer-sign -Wmissing-include-dirs 
-Wmissing-prototypes -Wmissing-declarations -Wformat=2 -target powerpc -Wl,-EB 
-m32 -msoft-float -Werror  -Wall -W  -DGRUB_MACHINE_IEEE1275=1 
-DGRUB_MACHINE=POWERPC_IEEE1275 conftest.c >&5 [  106s] clang version 3.6.1 
(tags/RELEASE_361/final 238133)
[  106s] Target: powerpc
[  106s] Thread model: posix
[  106s] clang-3.6: error: -Wl,-EB: 'linker' input unused


> > So I'd rather try to produce patch for proper support of
> > -mbig-endian/-mlittle-endian (including passing it onto gcc linker) and
> > until then declared clang on ppc64le having limited support (i.e.
> > support for automatic detection by configure).
> > 
> I agree that this is a better approach in long term. But if we can get
> some support for current tools with little work (see patch) and without
> risks of breaking other tools I see no reason not to go for it in short term
> > 
>

pgpTbuM29O_WE.pgp
Description: OpenPGP digital signature