Re: [PATCH] Parse commandline in grub-xen

[Vladimir 'phcoder' Serbinenko]

On May 11, 2015 7:08 PM, "Olaf Hering" <address@hidden> wrote:
>
> On Mon, May 11, Andrei Borzenkov wrote:
>
> > В Mon, 11 May 2015 14:15:54 +0200
> > Olaf Hering <address@hidden> пишет:
> >
> > > On Mon, May 11, Andrei Borzenkov wrote:
> > >
> > > > Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts
> > > > it) or by adding getarg command, something like
> > > >
> > > > getarg --name debug --set debug
> > >
> > > What would such format buy us?
> >
> > Make it possible for you, as script author, have control over which
> > arguments and how are used.
>
> 'if [ -n "${name}" ]' is simpler than
> 'getarg --name name --set name;if [ -n "${name}"]'.
> Not sure if 'if $cmd' is supposed to work, but either way your proposal
> looks strange.
>
> And regarding $debug itself, with my change its set very early before
> any script runs. Perhaps that is useful to debug early issues.
>
Even if it is, it shouldn't be a side effect of bad design
>
> Olaf
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel