Re: [PATCH 1/4] xfs: Add helper for inode size

[Jan Kara]

On Mon 11-05-15 14:53:57, Andrei Borzenkov wrote:
> В Mon, 14 Jul 2014 17:21:28 +0200
> Jan Kara <address@hidden> пишет:
> 
> > Signed-off-by: Jan Kara <address@hidden>
> > ---
> >  grub-core/fs/xfs.c | 17 +++++++++++------
> >  1 file changed, 11 insertions(+), 6 deletions(-)
> > 
> > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c
> > index 16ffd3f1ebd9..a2fc942707c1 100644
> > --- a/grub-core/fs/xfs.c
> > +++ b/grub-core/fs/xfs.c
> > @@ -255,6 +255,11 @@ grub_xfs_inode_offset (struct grub_xfs_data *data,
> >       data->sblock.log2_inode);
> >  }
> >  
> > +static inline int
> > +grub_xfs_inode_size(struct grub_xfs_data *data)
> 
> This should be grub_size_t.
  OK.

> What is the reason to add it? It does not look like subsequent
> patches modify this function like making it conditional on XFS version.
  This is just a cleanup so that it's clearer that 1 <<
data->sblock.log2_inode is actually inode size. But if you don't like it,
you can just skip it. So should I send update patch? Thanks for having a
look!

                                                                Honza
-- 
Jan Kara <address@hidden>
SUSE Labs, CR