Re: [PATCH] Parse commandline in grub-xen

[Andrei Borzenkov]

On Mon, May 11, 2015 at 12:43 PM, Olaf Hering <address@hidden> wrote:
> On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:
>
>> As said previously, allowing setting arbitrary variables from command line 
>> will
>> not be an accepted behavior. Also the code should be generic enough to allow
>> handling of other platforms if need be but surely without including any
>> unnecessary code for platforms that don't need it.

Each platform has own ways to pass arguments, so I'm not sure it makes
sense to really share this code. To this extent patch is OK as it is
specific to xen.

>                                                                               
>     Until there is an agreement
>> on how to handle the arguments, the only patch I would accept is to remove 
>> the
>> parser in ieee1275 code
>
> The function as is looks generic enough to be used by xen and ieee1275.
> Not sure why they went for ';' as separator, I'm sure the firmware does
> not require that.
> I dont have an EFI capable box around, someone familiar with that could
> make use of that function. I'm sure EFI has something like
> /chosen/bootargs.
>

EFI application gets analog of (argc, argv) directly. EFI arguments
are arbitrary binary blobs, but this is up to application to define
what is acceptable.

> Futhermore what freedom would you like to hand out to those who
> implement the scripts? In my testing some variables such as root= and
> prefix= are overriden anyway.
>

You do not know what variables will be used by modules/configuration files.