grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] lz4 overflow bug


From: Toomas Soome
Subject: [PATCH 2/2] lz4 overflow bug
Date: Wed, 15 Apr 2015 23:51:16 +0300

hi!

yep, this old bug is not fixed in grub. cpy can (theoretically?) overflow.

---
 grub-core/fs/zfs/zfs_lz4.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/grub-core/fs/zfs/zfs_lz4.c b/grub-core/fs/zfs/zfs_lz4.c
index 1212a89..ca6445d 100644
--- a/grub-core/fs/zfs/zfs_lz4.c
+++ b/grub-core/fs/zfs/zfs_lz4.c
@@ -185,6 +185,8 @@ LZ4_uncompress_unknownOutputSize(const char *source,
                }
                /* copy literals */
                cpy = op + length;
+               if (cpy < op)
+                       goto _output_error;
                if ((cpy > oend - COPYLENGTH) ||
                    (ip + length > iend - COPYLENGTH)) {
                        if (cpy > oend)
-- 
1.7.9.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]