grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device


From: Andrei Borzenkov
Subject: Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device
Date: Fri, 27 Feb 2015 17:15:25 +0300

On Fri, Feb 27, 2015 at 3:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko
<address@hidden> wrote:
> On 27.02.2015 13:06, Andrei Borzenkov wrote:
>>
>> On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko
>> <address@hidden> wrote:
>>>
>>> On 27.02.2015 12:47, Fajar A. Nugraha wrote:
>>>>
>>>>
>>>> +  lua_pushstring (state, label);
>>>
>>>
>>> What happens if label is NULL?
>>>
>>
>> In all cases if grub could mount filesystem it returns strdup(label).
>> Is it possible that mount fails without setting grub_errno? If yes, it
>> is probably a bug.
>>
> Nope. If filesystem has no label (rather than just empty label), it will
> have *label == NULL and return no error which is correct.

If filesystem has no label it should not define fs->label. Which
filesystem defines fs->label but returns NULL label?

>                                                                               
>        Same for UUID. So
> unless lua_pushstring has special handling for NULL, this code needs to be
> fixed.
>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> address@hidden
>>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]