Re: [PATCH] Add a module for retrieving SMBIOS information

[David Michael]

On Mon, Feb 2, 2015 at 3:06 PM, Leif Lindholm <address@hidden> wrote:
> On Sun, Feb 01, 2015 at 09:05:24PM -0500, David Michael wrote:
>> * grub-core/commands/i386/smbios.c: New file.
>> * grub-core/Makefile.core.def (smbios): New module.
>> * docs/grub.texi (smbios): New node.
>> (Command-line and menu entry commands): Add a menu entry for smbios.
>> ---
>>
>> Hi,
>>
>> There was some interest on help-grub about supporting SMBIOS access
>> upstream.  I've updated the module I wrote a while ago to work with
>> current GRUB and added documentation.  Is this acceptable to be applied?
>> Are there any comments or suggestions for improvement?
>
> Any particular reason for making it x86-only?
> Since the code correctly does _not_ scan memory for the tables on any
> EFI system, this should work without modification on arm/arm64 too.

It's marked as x86-only mostly because that's all I've tried, and I
didn't want to accidentally break builds for other configurations.  I
don't have any ARM hardware for testing the module.  Maybe an emulator
would suffice; I'll have to look into it.

Are you able to try the module with an ARM system?  I'd be happy to
update the patch with your suggested changes if it works.

Thanks.

David