grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Does grub-mkrescue support UEFI hybrid USB/DVD images?


From: Andrei Borzenkov
Subject: Re: Does grub-mkrescue support UEFI hybrid USB/DVD images?
Date: Fri, 23 Jan 2015 22:03:23 +0300

В Fri, 23 Jan 2015 21:38:27 +0300
Andrei Borzenkov <address@hidden> пишет:

> В Fri, 23 Jan 2015 19:29:07 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
> > 
> > > But returning (hd0,gpt2) would also be wrong here - ESP on CD image is
> > > empty, we need to somehow jump from ESP to full ISO image.
> > > 
> > Returning hd0,gpt2 is fine. By convention ()/file refers to parent disk
> > of whatever root partition is (as opposed to /file).
> 
> Not sure I follow. If you include part_gpt, grub will set prefix to
> (hd0,gpt2)/boot/grub. But /boot/grub does NOT exist there - it exists
> on (hd0), so correct prefix is (hd0)/boot/grub.
> 

Ah, OK, I see. Sorry.

> > So just including part_gpt in core should be enough. But perhaps we
> > should put my patch as well to increase reliability. Consider scenario
> > of installing on disk with gpt and apt and using apt partitions. GRUB
> > will properly detect that it needs part_apple but part_gpt is not needed
> > to access partition.
> > Most of the install tools specify partition explicitly, so having
> > partition is non-critical. Having disk on the hand is critical.
> > 
> > @Kris: Please try (after removing the other patch)

Yes, it works.

> > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c
> > index e719839..e02340f 100644
> > --- a/util/grub-mkrescue.c
> > +++ b/util/grub-mkrescue.c
> > @@ -653,6 +653,9 @@ main (int argc, char *argv[])
> >        char *efiimgfat;
> >        grub_install_mkdir_p (efidir_efi_boot);
> > 
> > +      grub_install_push_module ("part_gpt");
> > +      grub_install_push_module ("part_msdos");
> > +
> >        imgname = grub_util_path_concat (2, efidir_efi_boot, "bootia64.efi");
> >        make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI,
> > "ia64-efi", imgname);
> >        free (imgname);
> > @@ -713,6 +716,8 @@ main (int argc, char *argv[])
> >        free (efiimgfat);
> >        free (efidir_efi);
> >        free (efidir);
> > +      grub_install_pop_module ();
> > +      grub_install_pop_module ();
> >      }
> > 
> >    grub_install_push_module ("part_apple");
> > 
> > 
> 

Attachment: pgpHgDVu3Y9DT.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]