Re: [PATCH 0/5]arm64: Add multiboot support (via fdt) for Xen boot

[Fu Wei]

Hi everybody,

any suggestion for my patchset?

if these patches look fine, can they be merged?

Any feedback is welcome! :-)

Great thanks !

On 9 January 2015 at 00:38, Ian Campbell <address@hidden> wrote:

On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <address@hidden>
> Reviewed-by: Leif Lindholm <address@hidden>

I've tested the code at
git://git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
which I believe is the same as this posting on an AMD Seattle system
with a 40_custom containing:

        menuentry 'Baremetal' {
                insmod gzio
                insmod part_msdos
                insmod ext2
                set root='hd0,msdos2'
                search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
                linux /boot/vmlinuz console=ttyAMA0,115200n8 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }
        menuentry 'Xen' {
                insmod gzio
                insmod part_msdos
                insmod ext2
                set root='hd0,msdos2'
                search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
                multiboot /boot/xen no-bootscrub console=dtuart conswitch=x dtuart=/smb/address@hidden noreboot sync_console dom0_mem=256M dom0_max_vcpus=1
                module /boot/vmlinuz-xen console=hvc0 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }

(my system is too confused for 10_linux or 20_linux_xen right now, but I
believe this is representative of what they would emit)

The result was that I could boot both Baremetal and Xen via grub. So:

Tested-by: Ian Campbell <address@hidden>

I've not looked at the code (although I did review several older
iterations), would it be useful to the grub maintainers for me to do so?

Ian.

--

Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021