Re: Do not use O_SYNC

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Little old, but seems this was lost.  The relevant code seems to have
been moved to osdep/hostfile_unix.h, but it is still using O_SYNC and
I really don't see any reason why it should.  Can we please get rid of
this?

On 3/20/2013 10:15 AM, Phillip Susi wrote:
> revno: 164 committer: Phillip Susi <address@hidden> branch nick:
> raring timestamp: Wed 2013-03-20 10:00:03 -0400 message: Do not use
> O_SYNC
> 
> The disk was being opened with O_SYNC, and written to one sector at
> a time.  This has a huge time penalty, causing at least one 
> revolution of the disk per sector written. diff: === modified file
> 'grub-core/kern/emu/hostdisk.c' --- grub-core/kern/emu/hostdisk.c
> 2012-09-27 16:16:51 +0000 +++ grub-core/kern/emu/hostdisk.c
> 2013-03-20 14:00:03 +0000 @@ -848,9 +848,6 @@ #ifdef O_LARGEFILE 
> flags |= O_LARGEFILE; #endif -#ifdef O_SYNC -  flags |= O_SYNC; 
> -#endif #ifdef O_FSYNC flags |= O_FSYNC; #endif

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJUquEDAAoJENRVrw2cjl5RDW4H/2U8ICjqHovw8C/s+CFg7smW
q4/Wqpj8bEXHThL3yO+88cTB3q3I2/TGsunq/g4IsFqda3buXrRunHOg7IcNQQhy
JPSBWX7ucsFvi97bAwyh/iqns3MOlJlmnAGpM6yfwYPpyZOaCkU7ulJP0Hopc3LT
+JAq5V3V64GcknjbYhlvWB8K+eXaZ2s0NoIXAFA/ewhi7CQVE22PeQEhxH9rRbKQ
Or4FbGsoFwi+SL4PNuPShp+4H/sg8ewDA/gIVSjsThp9c3whq+nnGhVt28GfLZBc
1KtyeJCJ5HeKOgqzSh7BleUdxtApxFsUU2Fz5M/zyV6f5MidKfHlm8B65sUc+xM=
=HJul
-----END PGP SIGNATURE-----