Re: grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 04.12.2014 23:21, Felix Janda wrote:
> On 28.11.2014, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> On 21.11.2014 22:00, Felix Janda wrote:
>>> Hello,
>>>
>>> the file grub-core/osdep/unix/hostdisk.c has special code for glibc<2.1,
>>> which gets also pulled in for other libcs (such as musl libc) and makes
>>> compilation fail for them because the code uses glibc internals. The
>>> easiest way to fix is just to remove the code as the below patch does.
>>>
>> Don't assume that nobody will try to compile with ancient glibc. If you
>> want to raise the supported version for glibc you need to add a
>> configure check for presence of long offsets to configure and fail it if
>> it's not available. It should also be documented in INSTALL.
> 
> Before messing around with configure.ac, I'd like know whether a patch
> (correctly) implementing what you suggest would be accepted.
> 
Yes, I'll accept removing this clause as long as failure on ./configure
time is clear in case of no long-files available.
> Another solution I would be happy with, is to change the conditions
> 
> # if !defined(__GLIBC__) || \
>         ((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1)))
> 
> to
> 
> # ((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1)))
> 
> Felix
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

signature.asc
Description: OpenPGP digital signature