[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] efi: check *path non-null before grub_strrchr
|
From: |
Leif Lindholm |
|
Subject: |
Re: [PATCH] efi: check *path non-null before grub_strrchr |
|
Date: |
Wed, 5 Nov 2014 14:52:32 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 05, 2014 at 05:33:40PM +0300, Andrei Borzenkov wrote:
> On Wed, Nov 5, 2014 at 3:53 PM, Leif Lindholm <address@hidden> wrote:
> > The EFI version of grub_machine_get_bootlocation crops the boot image
> > name back to the last / in order to get a directory path. However, it
> > does not check that *name is actually set before calling grub_strrchr
> > to do this, and neither does grub_strrchr before dereferencing a NULL
> > pointer.
> >
>
> I wonder - do you actually have firmware that returns empty path?
I did (internal development version), and that's being fixed that end
too, but more graceful error handling in GRUB would still be nice.
/
Leif