Re: How can I submit patch for bug #42944 ?

[Rigoberto Corujo]

Hi,

Has a decision been made whether the GRUB2 project is going to go with my 
proposed patch that uses the UEFI SetTimer() function or whether the pmtimer 
patch will be used for the Hyper-V Generation 2 PXE boot issue?

Thank you,

Rigoberto


--------------------------------------------
On Fri, 10/17/14, Rigoberto Corujo <address@hidden> wrote:

 Subject: Re: How can I submit patch for bug #42944 ?
 To: "Andrei Borzenkov" <address@hidden>, "The development of GNU GRUB" 
<address@hidden>
 Cc: "The development of GNU GRUB" <address@hidden>, address@hidden
 Date: Friday, October 17, 2014, 10:29 AM
 
 Hi,
 
 Any update on this?
 
 Thanks,
 
 Rigoberto
 
 
 
 --------------------------------------------
 On Mon, 10/13/14, Rigoberto Corujo <address@hidden>
 wrote:
 
  Subject: Re: How can I
 submit patch for bug #42944 ?
  To:
 "Andrei Borzenkov" <address@hidden>,
 "The development of GNU GRUB" <address@hidden>
  Cc: "The development of GNU GRUB"
 <address@hidden>,
 address@hidden
  Date: Monday, October 13, 2014, 8:06 PM
  
  
 
 --------------------------------------------
  On Mon, 10/13/14, Rigoberto Corujo <address@hidden>
  wrote:
  
  
 Subject: Re: How
  can I submit patch for bug
 #42944 ?
   To:
 
 "Andrei Borzenkov" <address@hidden>,
  "The development of GNU GRUB" <address@hidden>
   Cc: "The development of GNU
 GRUB"
  <address@hidden>,
  address@hidden
   Date: Monday, October 13, 2014, 12:35 PM
   
   
  
 
 --------------------------------------------
   On Sun, 10/12/14, Andrei Borzenkov <address@hidden>
   wrote:
   
 
  
  Subject: Re: How
   can
 I submit patch for bug
  #42944 ?
    To:
  
 
 "Andrei Borzenkov" <address@hidden>
    Cc: "The development of GNU
  GRUB"
   <address@hidden>,
   address@hidden
    Date: Sunday, October 12, 2014, 12:24 PM
    
    В Sat, 11 Oct 2014
    12:58:29 +0400
   
 Andrei
   Borzenkov <address@hidden>
    пишет:
    
   
   > В Sat, 11
    Oct 2014 10:44:20 +0200
 
  
  > Vladimir
   
  
  'φ-coder/phcoder'
 Serbinenko <address@hidden>
    пишет:
    > 
    > >
    On
  10.10.2014
   23:23, Colin
 Watson wrote:
    > > >
   On Fri, Oct
  10, 2014 at
    04:44:39PM +0000,
  
 Rigoberto Corujo wrote:
   
 
 > > >>
   I attached a patch
 to
  bug
    #42944 and
 would
  
  like to know how I
 would go about getting
  
 
 
   it committed to the source tree?
    >
   >
    >> https://savannah.gnu.org/bugs/?42944
    > > > 
    >
  >
   >
 
   I'd
  suggest attaching the patch
 to
   a mail here
  (not
    encased in a zip
   
  > > > file). 
   
  
  It's usually easier to
 get public review that way.
    > >
 > 
    >
  >
   I
    don't like to
  use EFI timers if we
   can
 avoid them,
    they've been known
   
  > > to hang.
    Attached
   is a patch to
 use pmtimer for calibration
   
   > 
   
 
 > What about systems
    without ACPI?
  Does it explicitly exclude
  
 them?
    
    OK, I stay
   corrected. Still,
   
 this
  patch adds over 1K
  
 to kernel on
    i386-pc
   
 and
   about 0.5K to common core.img with
 ext2:
   
   
   
  -rw-r--r-- 1 bor bor 26848
 Oct
    12 20:09
 
 /tmp/core.img-pmtimer
    -rw-r--r-- 1
    bor bor 26320
   Oct 12
 18:50
  /tmp/core.img-vanilla
   
  
 
 -rwxr-xr-x 1 bor bor 29224 Oct 12 20:08
  
 
   /tmp/kernel.img-pmtimer
 
  
  -rwxr-xr-x 1 bor
  
 bor
   
  28060 Oct 12
 10:12
  
 
 /tmp/kernel.img-vanilla
    
    I
   think it's too
 much
  for
    something
 that
   so
  far is needed
 only on very
    specific
  
 platform. May be we could restrict it
   
 to
   EFI only where size
 
   does not matter that
   
 
 much?
    
   
  
  Attached rebased
    patch (I briefly
 
 checked
   and it still boots on i386-pc
    and
   apparently
 correctly
  handles timeouts, but
   
   I
 
 cannot check other
    platforms).
    -----Inline Attachment Follows-----
    
   
  
 
 _______________________________________________
    Grub-devel mailing list
 
  
  address@hidden
    https://lists.gnu.org/mailman/listinfo/grub-devel
    
   
  
 Thank
  you
   very much for
 the patch.  I will test
  it on Hyper-V
   Generation 2 and other
 
 physical UEFI servers and let you
   know
 the
  results.  Regarding the concern that
 was expressed
   about SetTimer() sometimes
 hanging on UEFI
  systems, the
   following two files are
 
 already using SetTimer().
   
  
 
 ./grub-core/kern/arm/efi/init.c
  
  ./grub-core/kern/ia64/efi/init.c
   
   Is it less likely that
 the
  
  hang occurs on those
 processors?
   
   Thank
 you,
   
  
 
 Rigoberto Corujo
  
 
 --------------------------------------------------------------------------
  
  I tried the pmtimer patch
 on
  Microsoft Hyper-V Generation 2, as well
 as a physical UEFI
  server, and it worked
 well.
  
  Please let me know
 if this patch is going to be
  submitted.
  
  Thank you,
 
 
  Rigoberto Corujo