Re: [PATCH] Fix build with glibc 2.20

[Andrei Borzenkov]

On Fri, Aug 29, 2014 at 6:34 AM, Khem Raj <address@hidden> wrote:
> * grub-core/kern/emu/hostfs.c: squahes below warning
>   warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use 
> _DEFAULT_SOURCE"

We still want it to compile under glibc < 2.20 as well. According to
ocumentation


To allow code that requires
              _BSD_SOURCE in glibc 2.19 and earlier and _DEFAULT_SOURCE in
              glibc 2.20 and later to compile without warnings, define both
              _BSD_SOURCE and _DEFAULT_SOURCE.

Could you test it and update patch accordingly?


>
> Signed-off-by: Khem Raj <address@hidden>
> ---
>  grub-core/kern/emu/hostfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/kern/emu/hostfs.c b/grub-core/kern/emu/hostfs.c
> index 7e725f6..8dd8e65 100644
> --- a/grub-core/kern/emu/hostfs.c
> +++ b/grub-core/kern/emu/hostfs.c
> @@ -19,7 +19,7 @@
>
>  #include <config-util.h>
>
> -#define _BSD_SOURCE
> +#define _DEFAULT_SOURCE
>  #include <grub/fs.h>
>  #include <grub/file.h>
>  #include <grub/disk.h>
> --
> 2.1.0
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel