Re: [PATCH] Fix ACPI halt for certain DSDTs

[Valentin Dornauer]

Thanks for the review, Andrey.

On 2 Jul 2014, at 19:56, Andrey Borzenkov <address@hidden> wrote:
>> +    in skip_ext_op(), correctly parse OpRegionOp (TermArgs aren't always
>> +    simply strings!); add function to skip TermArgs.
> 
> It does not really parse every possible value of Type2Opcode, so commit
> message should probably reflect it.
Done, I hope it’s clearer now.

> 
>> +    case GRUB_ACPI_OPCODE_ADD:
>> +    case GRUB_ACPI_OPCODE_CONCAT:
>> +    case GRUB_ACPI_OPCODE_SUBTRACT:
>> +    case GRUB_ACPI_OPCODE_MULTIPLY:
>> ...
> 
> Sort by name?
Done.

> 
>> +      if (add == 0)
>> +        return 0;
> 
> You use if (!add) in another places. Let's be consistent :)
Right, done.

> 
>>     GRUB_ACPI_OPCODE_NAME = 8, GRUB_ACPI_OPCODE_BYTE_CONST = 0x0a,
>> +    GRUB_ACPI_OPCODE_ALIAS = 0x06,
> 
> Looks like list is ordered by opcode value, so it should go between
> GRUB_ACPI_OPCODE_NAME and GRUB_ACPI_OPCODE_BYTE_CONST. Same also next hunk.
Done.

> 
>> +    GRUB_ACPI_OPCODE_CONCATRES = 0x80,
> 
> In my copy of ACPI spec ConcatRes has opcode 0x84.
Good catch, don’t know how that slipped through. While verifying the other 
opcodes
I stumbled upon some additional opcodes with the same operands: ModOp, IndexOp,
ToStringOp. I also included them in the new patch set.

- Valentin

0001-Fix-ACPI-halt-for-certain-DSDTs.patch
Description: Binary data

signature.asc
Description: Message signed with OpenPGP using GPGMail