Re: [RFC PATCH 21/23] powerpc64 is not necessarily BigEndian anymore! :)

[Andrey Borzenkov]

В Sat, 05 Apr 2014 17:45:30 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> A problem is that restgpr and [al]sh[lr]di3 weren't used by any
> platform.

What do you mean? They are used, but resolved from -lgcc for all
current platforms. Where it breaks is ppc64le where libgcc for BE does
not normally exist. And without -lgcc we get

[  152s] kern/powerpc/kernel_exec-dl.o: In function 
`grub_arch_dl_relocate_symbols':
[  152s] 
/home/abuild/rpmbuild/BUILD/grub-2.02~beta2/build/grub-core/../../grub-core/kern/powerpc/dl.c:167:
 undefined reference to `_restgpr_21_x'
[  152s] disk/ieee1275/kernel_exec-ofdisk.o: In function `grub_ofdisk_close':
[  152s] 
/home/abuild/rpmbuild/BUILD/grub-2.02~beta2/build/grub-core/../../grub-core/disk/ieee1275/ofdisk.c:448:
 undefined reference to `_restgpr_29_x'
...


>           Some other gcc versions probably use them. I'll need to figure
> out on which platforms.

Just set TARGET_LDFLAGS_STATIC_LIBGCC= and TARGET_LIBGCC= and try to
compile. If you intend to replace libgcc by internal implementation,
those flags are not needed anyway.

> restgpr is definitely ppc-only.
> [al]sh[lr]di3 I think was for arm.
> > 
> >> For ppc only ucmpdi2 was needed actually.
> > 
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> > 
> 
>

signature.asc
Description: PGP signature