grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 21/23] powerpc64 is not necessarily BigEndian anymore! :)


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [RFC PATCH 21/23] powerpc64 is not necessarily BigEndian anymore! :)
Date: Sat, 05 Apr 2014 17:45:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.3.0

On 04.04.2014 19:08, Andrey Borzenkov wrote:
> В Fri, 04 Apr 2014 08:37:20 +0200
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
>> As for eliminating libgcc dependency I created branch phcoder/no-libgcc.
> 
> I'm afraid it results in too much churn that will be unmanageable
> 
> module-cmos.o `test -f 'lib/ieee1275/cmos.c' || echo 
> '../../grub-core/'`lib/ieee1275/cmos.c
> [  140s] ../../grub-core/lib/relocator.c:655:2: error: implicit declaration 
> of function 'memset' [-Werror=implicit-function-declaration]
> [  140s]   memset (counter, 0, (1 + (1 << DIGITSORT_BITS)) * sizeof 
> (counter[0]));
> [  140s]   ^
> [  140s] ../../grub-core/lib/relocator.c:655:2: error: nested extern 
> declaration of 'memset' [-Werror=nested-externs]
> 
memset in GRUB code is a bug. I fixed the instances I've found and added
#define's to posix wrapping
> It is impossible to include compiler-rt.h from misc.h due to circular
> dependencies and it is near to impossible to find all places where
> compiler-rt.h has to be included (at least I do not have an idea).
> 
compiler-rt.,h shouldn't be included anywhere. The idea is that it
contains only functions used by compiler and never used by GRUB code.
> Someone will need to build test it for sparc, mips, arm (two flavors)
> and powerpc (three flavors).
I did all of this (I have a script).
A problem is that restgpr and [al]sh[lr]di3 weren't used by any
platform. Some other gcc versions probably use them. I'll need to figure
out on which platforms.
restgpr is definitely ppc-only.
[al]sh[lr]di3 I think was for arm.
> 
>> For ppc only ucmpdi2 was needed actually.
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]