RE: grub2 code

[Roger Cruz]

Yes,  that certainly would be a better fix.  Thanks for addressing it.

Roger

-----Original Message-----
From: Colin Watson [mailto:address@hidden 
Sent: Monday, February 03, 2014 10:51 AM
To: Roger Cruz
Cc: Ben Guthro; address@hidden
Subject: Re: grub2 code

On Mon, Feb 03, 2014 at 03:44:01PM +0000, Roger Cruz wrote:
> This was a bug that was introduced into GRUB when the code to detect 
> if the SHIFT key is being pressed was added.  The symptom was that 
> customers were complaining that even though they had turn on NUMLOCK 
> in the BIOS, once we booted our software, NUMLOCK was off.  It was 
> easy to "see" when the bug was happening because the NUMLOCK LED would 
> turn off sometime during GRUB running.
> 
> I tracked it down to that one line which ANDs the BIOS state area and 
> blows away the NUMLOCK state in it  (it stores the value in the 
> address in BX via indirect addressing).

Oh, of course, I missed the indirect store even on a second reading.
I'm pretty sure that the correct fix isn't to remove the code, but rather to 
use testb instead of andb.  I'll see about getting that fixed soon.

-- 
Colin Watson                                       address@hidden